kevinrr888 commented on code in PR #5547:
URL: https://github.com/apache/accumulo/pull/5547#discussion_r2124709427


##########
minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneAccumuloCluster.java:
##########
@@ -246,15 +246,14 @@ public AccumuloConfiguration getSiteConfiguration() {
       justification = "code runs in same security context as user who provided 
input file name")
   @Override
   public String getAccumuloPropertiesPath() {
-    return 
java.nio.file.Path.of(serverAccumuloConfDir).resolve("accumulo.properties").toFile()
-        .toString();
+    return 
java.nio.file.Path.of(serverAccumuloConfDir).resolve("accumulo.properties").toString();
   }
 
   @SuppressFBWarnings(value = "PATH_TRAVERSAL_IN",
       justification = "code runs in same security context as user who provided 
input file name")
   @Override
   public String getClientPropsPath() {
     return 
java.nio.file.Path.of(clientAccumuloConfDir).resolve("accumulo-client.properties")
-        .toFile().toString();
+        .toString();
   }

Review Comment:
   I'm not sure what you mean by non-internal-only code but if changing to Path 
would be too disruptive for this PR, keeping as String looks good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to