DomGarguilo commented on code in PR #5547:
URL: https://github.com/apache/accumulo/pull/5547#discussion_r2124491104
##########
minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneAccumuloCluster.java:
##########
@@ -246,15 +246,14 @@ public AccumuloConfiguration getSiteConfiguration() {
justification = "code runs in same security context as user who provided
input file name")
@Override
public String getAccumuloPropertiesPath() {
- return
java.nio.file.Path.of(serverAccumuloConfDir).resolve("accumulo.properties").toFile()
- .toString();
+ return
java.nio.file.Path.of(serverAccumuloConfDir).resolve("accumulo.properties").toString();
}
@SuppressFBWarnings(value = "PATH_TRAVERSAL_IN",
justification = "code runs in same security context as user who provided
input file name")
@Override
public String getClientPropsPath() {
return
java.nio.file.Path.of(clientAccumuloConfDir).resolve("accumulo-client.properties")
- .toFile().toString();
+ .toString();
}
Review Comment:
Yea it could. I didn't change certain return types since I didn't want to be
to disruptive with non-internal-only code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
