DomGarguilo commented on code in PR #5547: URL: https://github.com/apache/accumulo/pull/5547#discussion_r2124456475
########## core/src/test/java/org/apache/accumulo/core/classloader/ContextClassLoaderFactoryTest.java: ########## @@ -39,27 +40,33 @@ public class ContextClassLoaderFactoryTest extends WithTestNames { @TempDir - private static File tempFolder; + private static Path tempFolder; - private String uri1; - private String uri2; + private URL uri1; + private URL uri2; Review Comment: I think it makes more sense to keep them as URL since later in the test we compare them to other URL objects so we would need to do the conversion anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org