keith-turner commented on code in PR #5811:
URL: https://github.com/apache/accumulo/pull/5811#discussion_r2304660712
##########
server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java:
##########
@@ -84,15 +84,6 @@ public static void startServer(AbstractServer server, Logger
LOG) throws Excepti
e.printStackTrace();
LOG.error("{} died, exception thrown from runServer.",
server.getClass().getSimpleName(), e);
throw e;
- } finally {
Review Comment:
Do we still want to catch an exception and log here to achieve the goals of
#5796? I was commenting about catching Throwable because it was only added in
#5808 because of the finally. So not sure we need to catch Throwable, but may
still want to catch exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
