keith-turner commented on code in PR #5811:
URL: https://github.com/apache/accumulo/pull/5811#discussion_r2304327579
##########
server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java:
##########
@@ -84,15 +84,6 @@ public static void startServer(AbstractServer server, Logger
LOG) throws Excepti
e.printStackTrace();
LOG.error("{} died, exception thrown from runServer.",
server.getClass().getSimpleName(), e);
throw e;
- } finally {
Review Comment:
It was for logging an error in the case where finally threw an exception in
which case the error would be lost and would not propagate. W/o the finally
the error will propagate now. So it depends on what the outer code does with
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
