dlmarion commented on code in PR #5811:
URL: https://github.com/apache/accumulo/pull/5811#discussion_r2304604086
##########
server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java:
##########
@@ -476,8 +470,22 @@ public void startServiceLockVerificationThread() {
@Override
public void close() {
- if (context != null) {
- context.close();
+
+ context.getLowMemoryDetector().logGCInfo(getConfiguration());
+
+ // Must set shutdown as completed before calling super.close().
Review Comment:
Updated comment in ec5cd1d
##########
server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java:
##########
@@ -84,15 +84,6 @@ public static void startServer(AbstractServer server, Logger
LOG) throws Excepti
e.printStackTrace();
LOG.error("{} died, exception thrown from runServer.",
server.getClass().getSimpleName(), e);
throw e;
- } finally {
Review Comment:
Fixed in ec5cd1d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
