dlmarion commented on code in PR #6431:
URL: https://github.com/apache/accumulo/pull/6431#discussion_r3423446389
##########
shell/src/main/java/org/apache/accumulo/shell/commands/MergeCommand.java:
##########
@@ -52,6 +56,15 @@ public int execute(final String fullCommand, final
CommandLine cl, final Shell s
if (cl.hasOption(sizeOpt.getOpt())) {
size =
ConfigurationTypeHelper.getFixedMemoryAsBytes(cl.getOptionValue(sizeOpt.getOpt()));
}
+ if (tableName.equals(MetadataTable.NAME)) {
+ if (!shellState
+ .confirm(
+ " Warning!!! Merging the " + MetadataTable.NAME + " table
incorrectly can result in "
+ + "system instability. Are you REALLY sure you want to
merge?!?!?!")
Review Comment:
Merge will lock the metadata table for write and then unhost the tablets in
the range for some period of time while the merge occurs. The metadata tablets
could be unhosted under normal balance conditions, but the system will try to
host them immediately. I certainly think we should add a test case for this in
MergeIT or some other merge related IT. And I'm wondering if we should add a
merge of the metadata table during some Fate operations in some Fate IT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
