dlmarion commented on code in PR #6431:
URL: https://github.com/apache/accumulo/pull/6431#discussion_r3435592802
##########
shell/src/main/java/org/apache/accumulo/shell/commands/MergeCommand.java:
##########
@@ -52,6 +56,15 @@ public int execute(final String fullCommand, final
CommandLine cl, final Shell s
if (cl.hasOption(sizeOpt.getOpt())) {
size =
ConfigurationTypeHelper.getFixedMemoryAsBytes(cl.getOptionValue(sizeOpt.getOpt()));
}
+ if (tableName.equals(MetadataTable.NAME)) {
+ if (!shellState
+ .confirm(
+ " Warning!!! Merging the " + MetadataTable.NAME + " table
incorrectly can result in "
+ + "system instability. Are you REALLY sure you want to
merge?!?!?!")
Review Comment:
> For the FateITs it sounds like you want to see what system interruptions
might occur if merging the metadata table happened while other fate operation
are ongoing.
Exactly. It _should_ be fine as metadata tablets can become unhosted during
normal balancing, but it would be good to test this case since we are changing
the behavior of merge for the metadata table late in the development cycle in a
patch release. In fact, we may want to add that something to the message to say
that it's experimental if only to get users to test it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
