ddanielr commented on code in PR #6431:
URL: https://github.com/apache/accumulo/pull/6431#discussion_r3433081894


##########
core/src/main/java/org/apache/accumulo/core/util/Merge.java:
##########
@@ -109,10 +110,16 @@ public void start(String[] args) throws MergeException {
           System.err.println("table " + opts.tableName + " does not exist");
           return;
         }
+        if (RootTable.NAME.equals(opts.tableName)) {
+          throw new IllegalArgumentException("Cannot merge the root table");
+        }
         if (opts.goalSize == null || opts.goalSize < 1) {
           AccumuloConfiguration tableConfig =
               new 
ConfigurationCopy(client.tableOperations().getConfiguration(opts.tableName));
-          opts.goalSize = 
tableConfig.getAsBytes(Property.TABLE_SPLIT_THRESHOLD);
+          long newGoalSize = 
tableConfig.getAsBytes(Property.TABLE_SPLIT_THRESHOLD);

Review Comment:
   This code would previously just output a `Merging tablets in table <table> 
to <size> bytes` message but would not explicitly state that the size has 
changed from what was instructed.
   
   The new code change provides a message describing the change in the size 
selector.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to