https://issues.apache.org/bugzilla/show_bug.cgi?id=55489

--- Comment #5 from Stefan Bodewig <[email protected]> ---
Looking through the patch I fail to see where userAgent actually gets used.  It
is stored in GetThread but then?

One nit - I'd use the ant.version property rather than depending on Main, IDEs
may not be using Main and I wouldn't want to rely on its methods working
properly.

As for character validation for user agents: we could verify it contains only
proper tokens and is either ISO8859-1 or quoted, but I'd prefer to have the
underlying lib take care of that for us - if URLConnection doesn't fail, why
should we?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to