spacewander commented on code in PR #8006:
URL: https://github.com/apache/apisix/pull/8006#discussion_r1001393797
##########
t/discovery/consul_kv.t:
##########
@@ -218,6 +218,7 @@ routes:
GET /hello
--- response_body_like eval
qr/server [1-2]/
+--- ignore_error_log
Review Comment:
Why do we need to ignore error log in this file?
##########
t/kubernetes/discovery/kubernetes.t:
##########
@@ -224,6 +230,8 @@ GET /compare
Content-type: application/json
--- response_body
true
+--- error_log
+not found environment variable
Review Comment:
Could we provide dummy env var in this file to suppress repeated error msg?
##########
t/plugin/kafka-logger.t:
##########
@@ -148,6 +144,7 @@ GET /hello
--- response_body
hello world
--- wait: 2
+--- ignore_error_log
Review Comment:
Ditto
##########
t/kubernetes/discovery/kubernetes.t:
##########
@@ -286,3 +294,5 @@ GET /compare
Content-type: application/json
--- response_body
true
+--- error_log
+failed to get lua_shared_dict
Review Comment:
Would be better to add required shdict in the test nginx.conf?
##########
t/plugin/dubbo-proxy/upstream.t:
##########
@@ -88,6 +88,7 @@ routes:
#END
--- response_body
dubbo success
+--- ignore_error_log
Review Comment:
Why do we add ignore_error_log here?
##########
t/control/discovery.t:
##########
@@ -77,6 +73,8 @@ GET /t
--- response_body
{}
{"fetch_interval":3,"keepalive":true,"prefix":"upstreams","servers":["http://127.0.0.1:8500","http://127.0.0.1:8600"],"timeout":{"connect":2000,"read":2000,"wait":60},"weight":1}
+--- error_log
+connect consul
Review Comment:
Why do we need to check "connect consul" error log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
