spacewander commented on code in PR #8006:
URL: https://github.com/apache/apisix/pull/8006#discussion_r1005265221


##########
t/kubernetes/discovery/kubernetes.t:
##########
@@ -286,3 +294,5 @@ GET /compare
 Content-type: application/json
 --- response_body
 true
+--- error_log
+failed to get lua_shared_dict

Review Comment:
   But providing a correct conf would be better, instead of using a wrong conf 
and ignore the error.



##########
t/kubernetes/discovery/kubernetes.t:
##########
@@ -286,3 +294,5 @@ GET /compare
 Content-type: application/json
 --- response_body
 true
+--- error_log
+failed to get lua_shared_dict

Review Comment:
   But providing a correct conf would be better, instead of using a wrong conf 
and ignoring the error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to