starsz commented on code in PR #8162:
URL: https://github.com/apache/apisix/pull/8162#discussion_r1004280692


##########
apisix/plugin.lua:
##########
@@ -433,6 +438,8 @@ local function meta_filter(ctx, plugin_name, plugin_conf)
                          " plugin_name: ", plugin_name)
         return true
     end
+
+    ctx[match_cache_key] = ok

Review Comment:
   I think we can't cache the result of the filter. Since we have a different 
phase for every plugin like "rewrite", "access" e.g.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to