[GitHub] [apisix] soulbird commented on a diff in pull request #8162: fix: meta.filter in plugin doesn't work in response-rewrite plugin

Wed, 26 Oct 2022 23:22:09 -0700 


soulbird commented on code in PR #8162:
URL: https://github.com/apache/apisix/pull/8162#discussion_r1006443008


##########
apisix/plugin.lua:
##########
@@ -415,6 +415,12 @@ local function meta_filter(ctx, plugin_name, plugin_conf)
         return true
     end
 
+    local match_cache_key =
+        ctx.conf_type .. "#" .. plugin_name .. "#meta_filter_matched"

Review Comment:
   There is indeed a problem, I adjusted `match_cache_key`, added some test 
caseļ¼šhttps://github.com/apache/apisix/pull/8162/files#diff-29e2373df60fd8fc082317d17e636b6fa17c60459c1a691c5838f36b31cc486aR532-R567



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to