[GitHub] [apisix] spacewander commented on a diff in pull request #8162: fix: meta.filter in plugin doesn't work in response-rewrite plugin

Tue, 25 Oct 2022 23:54:34 -0700 


spacewander commented on code in PR #8162:
URL: https://github.com/apache/apisix/pull/8162#discussion_r1005287893


##########
apisix/plugin.lua:
##########
@@ -415,6 +415,12 @@ local function meta_filter(ctx, plugin_name, plugin_conf)
         return true
     end
 
+    local match_cache_key =
+        ctx.conf_type .. "#" .. plugin_name .. "#meta_filter_matched"

Review Comment:
   Does this key work with multiple global_rules? They have the same conf_type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to