spacewander commented on code in PR #8820:
URL: https://github.com/apache/apisix/pull/8820#discussion_r1113769051
##########
apisix/admin/resource.lua:
##########
@@ -31,27 +31,35 @@ local mt = {
}
+local no_id_res = {
+ consumers = {},
Review Comment:
```suggestion
consumers = true,
```
##########
apisix/admin/ssl.lua:
##########
@@ -46,9 +46,6 @@ local function check_conf(id, conf, need_id)
conf.id = id
- core.log.info("schema: ", core.json.delay_encode(core.schema.ssl))
Review Comment:
Let's avoid submitting the irrelevant change.
##########
apisix/admin/consumers.lua:
##########
@@ -16,25 +16,13 @@
--
local core = require("apisix.core")
local plugins = require("apisix.admin.plugins")
-local utils = require("apisix.admin.utils")
+local resource = require("apisix.admin.resource")
local plugin = require("apisix.plugin")
local pairs = pairs
-local _M = {
- version = 0.1,
- need_v3_filter = true,
-}
-
-local function check_conf(username, conf)
- -- core.log.error(core.json.encode(conf))
- if not conf then
Review Comment:
We can do the same with the plugin metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
