An-DJ commented on code in PR #8820:
URL: https://github.com/apache/apisix/pull/8820#discussion_r1113890141
##########
apisix/admin/consumers.lua:
##########
@@ -16,25 +16,13 @@
--
local core = require("apisix.core")
local plugins = require("apisix.admin.plugins")
-local utils = require("apisix.admin.utils")
+local resource = require("apisix.admin.resource")
local plugin = require("apisix.plugin")
local pairs = pairs
-local _M = {
- version = 0.1,
- need_v3_filter = true,
-}
-
-local function check_conf(username, conf)
- -- core.log.error(core.json.encode(conf))
- if not conf then
Review Comment:
It seems that the other resources may check additional conditions or
parameters before checking the schema.
Like the routes:
https://github.com/apache/apisix/blob/master/apisix/admin/routes.lua#L36
For these reasons, schema check cannot be moved to public code for the time
being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
