spacewander commented on code in PR #8820:
URL: https://github.com/apache/apisix/pull/8820#discussion_r1115156744
##########
apisix/admin/consumers.lua:
##########
@@ -16,25 +16,13 @@
--
local core = require("apisix.core")
local plugins = require("apisix.admin.plugins")
-local utils = require("apisix.admin.utils")
+local resource = require("apisix.admin.resource")
local plugin = require("apisix.plugin")
local pairs = pairs
-local _M = {
- version = 0.1,
- need_v3_filter = true,
-}
-
-local function check_conf(username, conf)
- -- core.log.error(core.json.encode(conf))
- if not conf then
Review Comment:
There is a common check in the
https://github.com/apache/apisix/blob/bc37568b0975edb7f111038610b66f5a4d908230/apisix/admin/resource.lua#L36
We don't need to repeat it in the custom checker. It's not about schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
