boekkooi-lengoo commented on code in PR #9010:
URL: https://github.com/apache/apisix/pull/9010#discussion_r1127524333
##########
apisix/plugins/cors.lua:
##########
@@ -37,7 +38,7 @@ local metadata_schema = {
type = "object",
additionalProperties = {
type = "string",
- pattern = origins_pattern
+ pattern = origins_metadata_pattern
Review Comment:
Because else the tests for the `metadata_schema` started failing and I don't
understand what `metadata_schema` is used for so I wanted to save and not sorry.
However if you are fine saying that an empty string is a valid origin we can
avoid this and I can fix the text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
