boekkooi-lengoo commented on code in PR #9010:
URL: https://github.com/apache/apisix/pull/9010#discussion_r1129073158
##########
apisix/plugins/cors.lua:
##########
@@ -37,7 +38,7 @@ local metadata_schema = {
type = "object",
additionalProperties = {
type = "string",
- pattern = origins_pattern
+ pattern = origins_metadata_pattern
Review Comment:
I think this is incorrect as the allow_origins can be empty or unspecified
if a regex is allow_origins_by_regex is specified.
However I didn't find any way to make `allow_origins` optional as it has a
default value of `*`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
