spacewander commented on code in PR #9010:
URL: https://github.com/apache/apisix/pull/9010#discussion_r1128845436
##########
apisix/plugins/cors.lua:
##########
@@ -37,7 +38,7 @@ local metadata_schema = {
type = "object",
additionalProperties = {
type = "string",
- pattern = origins_pattern
+ pattern = origins_metadata_pattern
Review Comment:
an empty string is not a valid origin. We can keep the same regex in
metadata_schema and the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
