zll600 commented on code in PR #10989: URL: https://github.com/apache/apisix/pull/10989#discussion_r1510533181
########## ci/linux_install_static_curl.sh: ########## @@ -0,0 +1,22 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +set -ex + +# use curl which supports http3 to test. +install_static_curl Review Comment: curl from apt does not support option --http3-only to test. So we need a newer version of curl ########## t/APISIX.pm: ########## @@ -777,7 +779,7 @@ _EOC_ set \$upstream_connection ''; set \$upstream_scheme 'http'; - set \$upstream_host \$http_host; + set \$upstream_host \$host; Review Comment: The value of variable $http_host header will be empty string when using http/3 ref: https://github.com/zulip/zulip/pull/26348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
