shreemaan-abhishek commented on code in PR #10989:
URL: https://github.com/apache/apisix/pull/10989#discussion_r1511333424
##########
apisix/cli/ops.lua:
##########
@@ -407,7 +413,12 @@ Please modify "admin_key" in conf/config.yaml .
if ip_port_to_check[addr] == nil then
table_insert(listen_table,
- {ip = ip, port = port, enable_http2 = enable_http2})
+ {
Review Comment:
can you explain the usage of this block briefly? And why this change is
needed.
##########
ci/common.sh:
##########
@@ -177,7 +186,7 @@ GRPC_SERVER_EXAMPLE_VER=20210819
linux_get_dependencies () {
apt update
- apt install -y cpanminus build-essential libncurses5-dev libreadline-dev
libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
+ apt install -y cpanminus build-essential libncurses5-dev libreadline-dev
libssl-dev perl libpcre3 libpcre3-dev libldap2-dev xz-utils
Review Comment:
I hope you checked if there is any other alternative way to install
static-url? Or install other tool? Or avoid installing it altogether.
##########
ci/common.sh:
##########
@@ -75,6 +75,15 @@ install_curl () {
curl -V
}
+install_static_curl () {
Review Comment:
if this is not going to be used anywhere else, better move it in quic.yaml.
##########
.github/workflows/quic.yml:
##########
@@ -0,0 +1,191 @@
+name: QUIC
+
+on:
+ push:
+ branches: [master, 'release/**']
+ paths-ignore:
+ - 'docs/**'
+ - '**/*.md'
+ pull_request:
+ branches: [master, 'release/**']
+ paths-ignore:
+ - 'docs/**'
+ - '**/*.md'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref == 'refs/heads/master' &&
github.run_number || github.ref }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+ build:
+ strategy:
+ fail-fast: false
+ matrix:
+ platform:
+ - ubuntu-20.04
+ os_name:
+ - linux_openresty
+ events_module:
+ - lua-resty-worker-events
+ - lua-resty-events
+ test_dir:
+ - t/quic/admin
+
+ runs-on: ${{ matrix.platform }}
+ timeout-minutes: 90
+ env:
+ SERVER_NAME: ${{ matrix.os_name }}
+ OPENRESTY_VERSION: default
+
+ steps:
+ - name: Check out code
+ uses: actions/checkout@v4
+ with:
+ submodules: recursive
+
+ - name: Setup Go
+ uses: actions/setup-go@v5
+ with:
+ go-version: "1.17"
+
+ - name: Cache deps
+ uses: actions/cache@v4
+ env:
+ cache-name: cache-deps
+ with:
+ path: deps
+ key: ${{ runner.os }}-${{ env.cache-name }}-${{ matrix.os_name
}}-${{ hashFiles('apisix-master-0.rockspec') }}
+
+ - name: Extract branch name
+ if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
+ id: branch_env
+ shell: bash
+ run: |
+ echo "version=${GITHUB_REF##*/}" >>$GITHUB_OUTPUT
+ echo "fullname=apache-apisix-${GITHUB_REF##*/}-src.tgz"
>>$GITHUB_OUTPUT
+
+ - name: Extract test type
+ shell: bash
+ id: test_env
+ run: |
+ test_dir="${{ matrix.test_dir }}"
+ if [[ $test_dir =~ 't/quic/plugin' ]]; then
Review Comment:
why do we need this if we are just testing basic.t?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
