membphis commented on code in PR #10989:
URL: https://github.com/apache/apisix/pull/10989#discussion_r1510768293
##########
t/node/http_host.t:
##########
@@ -64,5 +64,5 @@ GET /uri
Host: foo.com:1984
--- response_body
uri: /uri
-host: foo.com:1984
+host: foo.com
Review Comment:
same issue, I do not know why we need to update this test case
##########
conf/config-default.yaml:
##########
@@ -97,9 +97,11 @@ apisix:
listen: # APISIX listening port for
HTTPS traffic.
- port: 9443
enable_http2: true
+ enable_quic: true
Review Comment:
I don't think we should use `true` as default
`false` is better
##########
t/quic/admin/basic.t:
##########
@@ -0,0 +1,108 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+log_level('info');
+no_root_location();
+no_shuffle();
+run_tests();
+
+__DATA__
+
+=== TEST 1: create ssl for test.com
+--- config
+ location /t {
+ content_by_lua_block {
+ local core = require("apisix.core")
+ local t = require("lib.test_admin")
+
+ local ssl_cert = t.read_file("t/certs/apisix.crt")
+ local ssl_key = t.read_file("t/certs/apisix.key")
+ local data = {cert = ssl_cert, key = ssl_key, sni = "test.com"}
+
+ local code, body = t.test('/apisix/admin/ssls/1',
+ ngx.HTTP_PUT,
+ core.json.encode(data),
+ [[{
+ "value": {
+ "sni": "test.com"
+ },
+ "key": "/apisix/ssls/1"
+ }]]
+ )
+
+ ngx.status = code
+ ngx.say(body)
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+
+
+
+=== TEST 2: Successfully access test.com with QUIC
+--- config
+ location /echo {
+ echo world;
+ }
+--- exec
+curl -k -v -H "Host: test.com" -H "content-length: 0" --http3-only --resolve
"test.com:1994:127.0.0.1" https://test.com:1994/echo 2>&1 | cat
+--- response_body eval
+qr/world/
+
+
+
+=== TEST 3: set route
+--- config
+location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:1980": 1
+ },
+ "type": "roundrobin"
+ },
+ "uris": ["/hello", "/world"]
Review Comment:
only `/hello` should be enough
##########
t/node/grpc-proxy.t:
##########
@@ -219,7 +219,7 @@ grpcurl -import-path ./t/grpc_server_example/proto -proto
helloworld.proto -plai
--- grep_error_log eval
qr/grpc header: "(:authority|host): [^"]+"/
--- grep_error_log_out eval
-qr/grpc header: "(:authority|host): 127.0.0.1:1984"/
+qr/grpc header: "(:authority|host): 127.0.0.1"/
Review Comment:
I don't think we need to update this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
