pottekkat commented on code in PR #1789:
URL: https://github.com/apache/apisix-website/pull/1789#discussion_r1579920153
##########
doc/src/pages/edit.tsx:
##########
@@ -20,18 +22,26 @@ const Edit: FC = () => {
const path = getPath();
setIsLoading(true);
+
+ if (path === '' || !path.includes('https://github.com/apache')) {
+ setPathExist(false);
+ setIsLoading(false);
+ return;
+ }
+
fetch(path.replace('github.com',
'raw.githubusercontent.com').replace('/edit', ''))
.then((res) => setPathExist(res.status !== 404))
.finally(() => setIsLoading(false));
}, []);
const edit = useCallback(() => {
- let path = getPath();
+ const path = getPath();
+
if (!pathExist) {
- const pathArr = path.replace('edit', 'new').split('/');
- pathArr[pathArr.length - 1] = `?filename=${pathArr.at(-1)}`;
- path = pathArr.join('/');
Review Comment:
Not sure if this is ever run but it seems like it is for creating a new file
if doesn't exist?
Should we replace this logic?
Maybe instead we can add to this logic and set a new condition for an empty
path. Because path does not exist and path is empty are different.
Again, I'm not sure if it is ever run so IDK if it would be any problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
