siyaramaa commented on code in PR #1789:
URL: https://github.com/apache/apisix-website/pull/1789#discussion_r1581768238
##########
doc/src/pages/edit.tsx:
##########
@@ -20,18 +22,26 @@ const Edit: FC = () => {
const path = getPath();
setIsLoading(true);
+
+ if (path === '' || !path.includes('https://github.com/apache')) {
+ setPathExist(false);
+ setIsLoading(false);
+ return;
+ }
+
fetch(path.replace('github.com',
'raw.githubusercontent.com').replace('/edit', ''))
.then((res) => setPathExist(res.status !== 404))
.finally(() => setIsLoading(false));
}, []);
const edit = useCallback(() => {
- let path = getPath();
+ const path = getPath();
+
if (!pathExist) {
- const pathArr = path.replace('edit', 'new').split('/');
- pathArr[pathArr.length - 1] = `?filename=${pathArr.at(-1)}`;
- path = pathArr.join('/');
Review Comment:
Hi, It looks like the code isn't creating new files.
I think it's attempting to replace the path, for example, from
'/edit/#githubrepolink' to '/new/?filename=githubrepolink' if it doesn't exist.
But, we're using getPath = () => window.location.hash.slice(1); to retrieve the
path, which only gives us the hash - "githubrepolink'".
So, it seems that this logic isn't being utilized. Please correct me if I'm
wrong. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
