SkyeYoung commented on code in PR #1789:
URL: https://github.com/apache/apisix-website/pull/1789#discussion_r1584217518


##########
doc/src/pages/edit.tsx:
##########
@@ -20,18 +22,26 @@ const Edit: FC = () => {
     const path = getPath();
 
     setIsLoading(true);
+
+    if (path === '' || !path.includes('https://github.com/apache')) {
+      setPathExist(false);
+      setIsLoading(false);
+      return;
+    }

Review Comment:
   You can move this part of the code up 24 lines, you should not need to 
`setIsLoading(false)` this way.
   
   Also `if(xxx)` can be written as `if(!path?.includes(INDEX_URL))` 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to