siyaramaa commented on code in PR #1789:
URL: https://github.com/apache/apisix-website/pull/1789#discussion_r1586242910
##########
doc/src/pages/edit.tsx:
##########
@@ -20,18 +22,26 @@ const Edit: FC = () => {
const path = getPath();
setIsLoading(true);
+
+ if (path === '' || !path.includes('https://github.com/apache')) {
+ setPathExist(false);
+ setIsLoading(false);
+ return;
+ }
+
fetch(path.replace('github.com',
'raw.githubusercontent.com').replace('/edit', ''))
.then((res) => setPathExist(res.status !== 404))
.finally(() => setIsLoading(false));
}, []);
const edit = useCallback(() => {
- let path = getPath();
+ const path = getPath();
+
if (!pathExist) {
- const pathArr = path.replace('edit', 'new').split('/');
- pathArr[pathArr.length - 1] = `?filename=${pathArr.at(-1)}`;
- path = pathArr.join('/');
Review Comment:
Hi @SkyeYoung, Thanks for explaining. I finally understand how it's supposed
to work, I had misunderstood before. The modified logic should redirect the
user to the index URL if it doesn't exist. Should I revert it back to the logic
of redirecting to GitHub create new file? Thanks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
