flea1lt commented on code in PR #11247:
URL: https://github.com/apache/apisix/pull/11247#discussion_r1597790338


##########
docs/en/latest/plugins/opentelemetry.md:
##########
@@ -66,6 +66,14 @@ You can set up the collector by configuring it in you 
configuration file (`conf/
 | batch_span_processor.max_export_batch_size | integer | 256                   
                            | Maximum number of spans to process in a single 
batch.                                                                          
                                                                                
               |
 | batch_span_processor.inactive_timeout      | number  | 2                     
                            | Time interval in seconds between processing 
batches.                                                                        
                                                                                
                  |
 
+:::note
+
+When the `trace_id_source` is set to `x-request-id` and requests carry an 
`x-request-id` header generated by Envoy, there may be issues pushing traces to 
the collector.
+
+This occurs because Envoy generates its `x-request-id` header using 
[UUID](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/observability/tracing#trace-context-propagation)
 by default, which does not match the specified regex pattern `[0-9a-f]{32}`.

Review Comment:
   No. OpenTelemetry requires a 32-hex-character lowercase string as traceId. 
Users must ensure that the traceId matches the pattern [0-9a-f]{32}. I have 
linked OpenTelemetry's traceId format at commit 
https://github.com/apache/apisix/pull/11247/commits/83181fce6dbf8e00e55318a16cece89ca2681dc8.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to