shreemaan-abhishek commented on code in PR #11247:
URL: https://github.com/apache/apisix/pull/11247#discussion_r1602590535
##########
conf/config-default.yaml:
##########
@@ -571,13 +571,13 @@ plugin_attr: # Plugin attributes
request_headers: # Set the headers to include in requests
to the OpenTelemetry collector.
Authorization: token # Set the authorization header to include
an access token.
batch_span_processor:
- drop_on_queue_full: false # Drop spans when the export queue is full.
- max_queue_size: 1024 # Set the maximum size of the span export
queue.
- batch_timeout: 2 # Set the timeout for span batches to wait
in the export queue before
+ drop_on_queue_full: true # Drop spans when the export queue is full.
Review Comment:
the default values in apisix config file would have been set considering
APISIX's use cases. Updating the doc would be better also because existing
users might already be relying on the default values, changing them would lead
to another effort being required during version upgrade, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
