flea1lt commented on code in PR #11247:
URL: https://github.com/apache/apisix/pull/11247#discussion_r1599491187
##########
conf/config-default.yaml:
##########
@@ -571,13 +571,13 @@ plugin_attr: # Plugin attributes
request_headers: # Set the headers to include in requests
to the OpenTelemetry collector.
Authorization: token # Set the authorization header to include
an access token.
batch_span_processor:
- drop_on_queue_full: false # Drop spans when the export queue is full.
- max_queue_size: 1024 # Set the maximum size of the span export
queue.
- batch_timeout: 2 # Set the timeout for span batches to wait
in the export queue before
+ drop_on_queue_full: true # Drop spans when the export queue is full.
Review Comment:
Because the doc and the values in config-default.yaml are different, we need
to align them by updating either the doc or the default config file.
The current apisix doc aligns its values with
[opentelemetry-lua](https://github.com/yangxikun/opentelemetry-lua/blob/main/lib/opentelemetry/trace/batch_span_processor.lua#L106),
which is the dependency used by the plugin. Therefore, it may be preferable to
correct the default configuration file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
