ronething opened a new pull request, #11430:
URL: https://github.com/apache/apisix/pull/11430

   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   Fixes # (issue)
   
   ## Background
   
   the `load_full_data` function in the file `config_etcd.lua`(load all exist 
data from etcd when apisix start), `checker` does not depend on `item_schema` 
to have a value
   
   
https://github.com/apache/apisix/blob/507df1262de88c4ed3ee8a637de46c4f4d2412f8/apisix/core/config_etcd.lua#L540-L546
   
   But in the `sync_data` function (watch new events from etcd when apisix 
running), `checker` relies on `item_schema` should have value.
   
   
https://github.com/apache/apisix/blob/507df1262de88c4ed3ee8a637de46c4f4d2412f8/apisix/core/config_etcd.lua#L668
   
   As a result, the plugin metadata resource cannot reach the checker logic 
when etcd watch.
   
   
https://github.com/apache/apisix/blob/507df1262de88c4ed3ee8a637de46c4f4d2412f8/apisix/plugin.lua#L816-L821
   
   So we need to fix it.
   
   ###  about the test case:
   
   The admin api is not used for the operation, because the admin api will 
directly fail to verify the schema and cannot go to the etcd checker logic.
   
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to