moonming commented on code in PR #11430:
URL: https://github.com/apache/apisix/pull/11430#discussion_r1697831047
##########
t/admin/plugin-metadata.t:
##########
@@ -274,7 +274,7 @@ qr/\{"error_msg":"invalid configuration: property
\\"ikey\\" is required"\}/
}
}
--- response_body
-{"key":"/apisix/plugin_metadata/example-plugin","value":{"ikey":1,"skey":"val"}}
+{"key":"/apisix/plugin_metadata/example-plugin","value":{"id":"example-plugin","ikey":1,"skey":"val"}}
Review Comment:
why change this?
##########
t/plugin/error-log-logger-clickhouse.t:
##########
@@ -98,7 +98,7 @@ done
--- error_log
this is a warning message for test2
clickhouse body: INSERT INTO t FORMAT JSONEachRow
-clickhouse headers: x-clickhouse-key:dpwomMlEsHH2L7wSUi6YiQ==
+clickhouse headers: x-clickhouse-key:a
Review Comment:
why change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
