ronething commented on code in PR #11430:
URL: https://github.com/apache/apisix/pull/11430#discussion_r1697835948
##########
apisix/plugins/sls-logger.lua:
##########
@@ -63,7 +63,11 @@ local schema = {
local metadata_schema = {
type = "object",
- properties = {log_format = log_util.metadata_schema_log_format,},
+ properties = {
+ log_format = {
+ type = "object"
+ }
+ },
Review Comment:
Originally sls-logger didn't add the metadata_schema, and then because the
etcd checker didn't take effect before, it couldn't detect the problem.
As for the metadata schema, I refer to file-logger.
https://github.com/apache/apisix/blob/2f6fd50121c545742a902cf838287406d103566a/apisix/plugins/file-logger.lua#L63-L70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
