Revolyssup commented on code in PR #2501:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2501#discussion_r2265765758
##########
test/e2e/crds/v2/route.go:
##########
@@ -42,20 +42,20 @@ import (
var _ = Describe("Test ApisixRoute", Label("apisix.apache.org", "v2",
"apisixroute"), func() {
var (
s = scaffold.NewScaffold(&scaffold.Options{
- ControllerName:
"apisix.apache.org/apisix-ingress-controller",
+ ControllerName:
fmt.Sprintf("apisix.apache.org/apisix-ingress-controller-%d",
time.Now().Unix()),
})
applier = framework.NewApplier(s.GinkgoT, s.K8sClient,
s.CreateResourceFromString)
)
BeforeEach(func() {
By("create GatewayProxy")
- gatewayProxy := fmt.Sprintf(gatewayProxyYaml,
s.Deployer.GetAdminEndpoint(), s.AdminKey())
- err := s.CreateResourceFromStringWithNamespace(gatewayProxy,
"default")
+ gatewayProxy := getGatewayProxyYaml(s.Namespace(),
s.Deployer.GetAdminEndpoint(), s.AdminKey())
+ err := s.CreateResourceFromStringWithNamespace(gatewayProxy,
s.Namespace())
Expect(err).NotTo(HaveOccurred(), "creating GatewayProxy")
time.Sleep(5 * time.Second)
By("create IngressClass")
- err = s.CreateResourceFromStringWithNamespace(ingressClassYaml,
"")
+ err =
s.CreateResourceFromStringWithNamespace(getIngressClassYaml(s.Namespace(),
s.GetControllerName(), s.Namespace()), "")
Review Comment:
CreateResourceFromString will use scaffold's namespace. Although that will
be ignored but ideally we dont want to pass the namespace when creating cluster
scoped resources. By explicitly adding empty namespace, --namespace will not be
passed while creating IngressClass. I think its okay to keep it this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
