Revolyssup commented on code in PR #2501:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2501#discussion_r2265964187
##########
test/e2e/crds/v1alpha1/backendtrafficpolicy.go:
##########
@@ -19,21 +19,28 @@ package v1alpha1
import (
"fmt"
+ "time"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
+ "k8s.io/apimachinery/pkg/types"
"github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
)
var _ = Describe("Test BackendTrafficPolicy base on HTTPRoute",
Label("apisix.apache.org", "v1alpha1", "backendtrafficpolicy"), func() {
- s := scaffold.NewDefaultScaffold()
+ var (
+ s = scaffold.NewScaffold(&scaffold.Options{
+ ControllerName:
fmt.Sprintf("apisix.apache.org/apisix-ingress-controller-%d",
time.Now().Unix()),
Review Comment:
I have reverted back to this behavior. I see a lot of tests fail when
defaultScaffold is used. I am looking into the reason but for now I have
reverted to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
