Revolyssup commented on code in PR #2501: URL: https://github.com/apache/apisix-ingress-controller/pull/2501#discussion_r2272221243
########## test/e2e/crds/v2/route.go: ########## @@ -68,8 +68,9 @@ apiVersion: apisix.apache.org/v2 kind: ApisixRoute metadata: name: default + namespace: %s Review Comment: Yes maybe its redundant, do you want to me to remove it from everywhere? It doesn't matter except for maybe these changes might have added strain in the review process. For a good practice, I was being explicit with namespaces so that in the rest 5% of the cases I dont make a mistake if I make a general rule to specify namespaces explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
