nic-6443 commented on code in PR #12686:
URL: https://github.com/apache/apisix/pull/12686#discussion_r2464486398
##########
apisix/core/response.lua:
##########
@@ -86,6 +89,9 @@ function resp_exit(code, ...)
end
if code then
+ if code >= 400 then
+ tracer.finish_current_span(tracer.status.ERROR, message or
("response code " .. code))
Review Comment:
I think we should finish all pending spans in here, not only current span,
we should provide another util function in `tracer` for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
