spacewander commented on a change in pull request #3201:
URL: https://github.com/apache/apisix/pull/3201#discussion_r552357936
##########
File path: apisix/schema_def.lua
##########
@@ -688,7 +688,9 @@ _M.global_rule = {
type = "object",
properties = {
id = id_schema,
- plugins = plugins_schema
+ plugins = plugins_schema,
+ create_time = timestamp_def,
+ update_time = timestamp_def
Review comment:
Need to inject the time when creating global rule, like this:
https://github.com/apache/apisix/blob/7c5df5d343ef79f9a292a8eb621fec72280d13ea/apisix/admin/routes.lua#L200
Also need to update the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
