imjoey commented on a change in pull request #3201:
URL: https://github.com/apache/apisix/pull/3201#discussion_r552389887
##########
File path: apisix/schema_def.lua
##########
@@ -688,7 +688,9 @@ _M.global_rule = {
type = "object",
properties = {
id = id_schema,
- plugins = plugins_schema
+ plugins = plugins_schema,
+ create_time = timestamp_def,
+ update_time = timestamp_def
Review comment:
@spacewander PR renewed, with add missing time injection as well as
relevant test cases. Regarding to doc, sorry for not getting where I can add,
the
https://github.com/apache/apisix/blob/master/doc/architecture-design.md#global-rule
seems no need to mentioned that. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
