imjoey commented on a change in pull request #3201:
URL: https://github.com/apache/apisix/pull/3201#discussion_r552378389
##########
File path: apisix/schema_def.lua
##########
@@ -688,7 +688,9 @@ _M.global_rule = {
type = "object",
properties = {
id = id_schema,
- plugins = plugins_schema
+ plugins = plugins_schema,
+ create_time = timestamp_def,
+ update_time = timestamp_def
Review comment:
@spacewander oh, good catch. I forgot that the Admin API is still in use
and APISIX can also write the two fields into etcd. I would re-new this PR
soon, as well as the docs and more test cases. Thank you very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
