nic-chen commented on a change in pull request #1324:
URL: https://github.com/apache/apisix-dashboard/pull/1324#discussion_r559549210
##########
File path: api/internal/core/store/store.go
##########
@@ -35,8 +35,8 @@ import (
)
type Interface interface {
- Get(key string) (interface{}, error)
- List(input ListInput) (*ListOutput, error)
+ Get(ctx context.Context, key string) (interface{}, error)
+ List(ctx context.Context, input ListInput) (*ListOutput, error)
Review comment:
we don't use it currently, but it's is convenient to pass custom
parameters or other data in custom development
##########
File path: api/internal/core/store/store.go
##########
@@ -136,8 +136,9 @@ func (s *GenericStore) Init() error {
return nil
}
-func (s *GenericStore) Get(key string) (interface{}, error) {
+func (s *GenericStore) Get(ctx context.Context, key string) (interface{},
error) {
ret, ok := s.cache.Load(key)
+ _ = ctx
Review comment:
fixed.
##########
File path: api/internal/core/store/store.go
##########
@@ -173,8 +174,9 @@ var defLessFunc = func(i, j interface{}) bool {
return iID < jID
}
-func (s *GenericStore) List(input ListInput) (*ListOutput, error) {
+func (s *GenericStore) List(ctx context.Context, input ListInput)
(*ListOutput, error) {
var ret []interface{}
+ _ = ctx
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
