ShiningRush commented on a change in pull request #1324:
URL: https://github.com/apache/apisix-dashboard/pull/1324#discussion_r559577039
##########
File path: api/internal/core/store/store.go
##########
@@ -35,8 +35,8 @@ import (
)
type Interface interface {
- Get(key string) (interface{}, error)
- List(input ListInput) (*ListOutput, error)
+ Get(ctx context.Context, key string) (interface{}, error)
+ List(ctx context.Context, input ListInput) (*ListOutput, error)
Review comment:
Keep parameter enough would be better, is here any concret cases which
must need context? It will need context only when do some io operations(disk io
or network io) as far as I know, store is responsible to query data in memory,
so it looks like will never do IO operations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
