nic-chen commented on a change in pull request #1324:
URL: https://github.com/apache/apisix-dashboard/pull/1324#discussion_r559663079
##########
File path: api/internal/core/store/store.go
##########
@@ -35,8 +35,8 @@ import (
)
type Interface interface {
- Get(key string) (interface{}, error)
- List(input ListInput) (*ListOutput, error)
+ Get(ctx context.Context, key string) (interface{}, error)
+ List(ctx context.Context, input ListInput) (*ListOutput, error)
Review comment:
For example, there may be some business parameters that need to be
passed. If we pass these custom parameters one by one, the handler code needs
to be modified, and the code will be conflicts with upstream. If use `ctx` to
deliver, user only need to pay attention to the business part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
