tokers commented on a change in pull request #161: URL: https://github.com/apache/apisix-docker/pull/161#discussion_r611276033
########## File path: README.md ########## @@ -11,27 +11,27 @@ # Assign Apache release version number to variable `APISIX_VERSION`, for example: 2.4. The latest version can be find at `https://github.com/apache/apisix/releases` export APISIX_VERSION=2.4 -docker build -t apisix:${APISIX_VERSION}-alpine --build-arg APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine +make -t apisix:${APISIX_VERSION}-alpine --build-arg APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine Review comment: Well, all the following options are used for `docker`, not for `make`. I bet this command will fail when running. All the options should be encapsulated into the make directive, please seeing https://github.com/apache/apisix-docker/blob/master/Makefile for more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
