Yiyiyimu commented on a change in pull request #161: URL: https://github.com/apache/apisix-docker/pull/161#discussion_r612964805
########## File path: README.md ########## @@ -11,27 +11,30 @@ # Assign Apache release version number to variable `APISIX_VERSION`, for example: 2.4. The latest version can be find at `https://github.com/apache/apisix/releases` export APISIX_VERSION=2.4 -docker build -t apisix:${APISIX_VERSION}-alpine --build-arg APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine +# alpine +make build-on-alpine +# centos +make build-on-centos ``` 2. Build from master branch version, which has latest code(ONLY for the developer's convenience): ``` export APISIX_VERSION=master -docker build -t apisix:${APISIX_VERSION}-alpine --build-arg APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine +make -t apisix:${APISIX_VERSION}-alpine --build-arg APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine Review comment: more places need to be fixed @iamayushdas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
