Yiyiyimu commented on a change in pull request #161:
URL: https://github.com/apache/apisix-docker/pull/161#discussion_r613260603
##########
File path: README.md
##########
@@ -12,29 +12,33 @@
export APISIX_VERSION=2.4
# alpine
-make build-on-alpine
+$ make build-on-alpine
# centos
-make build-on-centos
+$ make build-on-centos
```
2. Build from master branch version, which has latest code(ONLY for the
developer's convenience):
```
export APISIX_VERSION=master
-make -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine
+# alpine
+$ make build-on-alpine
+# centos
+$ make build-on-centos
```
3. Build from local code:
```
# To copy apisix into image, we need to include it in build context
-cd <APISIX-PATH>
-make -t apisix:alpine-local --build-arg APISIX_PATH=. -f
<APISIX-DOCKER-PATH>/alpine-local/Dockerfile alpine
+$ cd <APISIX-PATH>
+# alpine-local
+$ make build-on-alpine-local
Review comment:
We need to set environment ${APISIX_PATH} first here, see Makefile
##########
File path: README.md
##########
@@ -12,29 +12,33 @@
export APISIX_VERSION=2.4
# alpine
-make build-on-alpine
+$ make build-on-alpine
# centos
-make build-on-centos
+$ make build-on-centos
```
2. Build from master branch version, which has latest code(ONLY for the
developer's convenience):
```
export APISIX_VERSION=master
-make -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine
+# alpine
+$ make build-on-alpine
+# centos
+$ make build-on-centos
```
3. Build from local code:
```
# To copy apisix into image, we need to include it in build context
-cd <APISIX-PATH>
-make -t apisix:alpine-local --build-arg APISIX_PATH=. -f
<APISIX-DOCKER-PATH>/alpine-local/Dockerfile alpine
+$ cd <APISIX-PATH>
+# alpine-local
Review comment:
we could remove this line alpine-local is just a random name 🤣
##########
File path: Makefile
##########
@@ -34,6 +34,12 @@ build-on-alpine:
build-on-alpine-local:
docker build -t $(IMAGE_NAME):$(APISIX_VERSION)-alpine-local
--build-arg APISIX_PATH=${APISIX_PATH} -f ./alpine-local/Dockerfile .
+### build-on-alpine-cn: Build apache/apisix:xx-alpine image
(for chinese)
Review comment:
need to add another line of function name, now you comment it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
