Yiyiyimu commented on a change in pull request #161:
URL: https://github.com/apache/apisix-docker/pull/161#discussion_r614629880
##########
File path: README.md
##########
@@ -30,15 +30,18 @@ $ make build-on-centos
```
# To copy apisix into image, we need to include it in build context
$ cd <APISIX-PATH>
-# alpine-local
-$ make build-on-alpine-local
+
+# alpine
+
+$ APISIX_PATH=/path/to/apisix make build-on-alpine-local
+
# Might need root privilege if encounter "error checking context: 'can't stat'"
```
**Note:** For Chinese, the following command is always recommended. The
additional build argument `ENABLE_PROXY=true` will enable proxy to definitely
accelerate the progress.
```sh
-$ make build-on-alpine-cn
+$ docker build -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} --build-arg ENABLE_PROXY=true -f
alpine/Dockerfile alpine
Review comment:
```suggestion
$ make build-on-alpine-cn
```
##########
File path: Makefile
##########
@@ -34,8 +34,8 @@ build-on-alpine:
build-on-alpine-local:
docker build -t $(IMAGE_NAME):$(APISIX_VERSION)-alpine-local
--build-arg APISIX_PATH=${APISIX_PATH} -f ./alpine-local/Dockerfile .
-### build-on-alpine-cn: Build apache/apisix:xx-alpine image
(for chinese)
- docker build -t $(IMAGE_NAME):${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} --build-arg ENABLE_PROXY=true -f
alpine/Dockerfile alpine
+# build-on-alpine-cn: Build apache/apisix:xx-alpine image (for
chinese)
+# docker build -t $(IMAGE_NAME):${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} --build-arg ENABLE_PROXY=true -f
alpine/Dockerfile alpine
Review comment:
```suggestion
build-on-alpine-cn:
docker build -t $(IMAGE_NAME):${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} --build-arg ENABLE_PROXY=true -f
alpine/Dockerfile alpine
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
