gxthrj commented on a change in pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#discussion_r631131965
##########
File path: .github/workflows/apisix_push_docker_hub.yaml
##########
@@ -15,10 +15,27 @@ jobs:
- name: Check out the repo
uses: actions/checkout@v2
+ # Setup Buildx builder
+ - name: Setup Docker Buildx
+ uses: docker/setup-buildx-action@v1
+
+ # Login
- name: Login
- run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login --username=${{
secrets.DOCKER_USERNAME }} --password-stdin
+ uses: docker/login-action@v1
+ with:
+ username: ${{ secrets.DOCKER_USERNAME }}
+ password: ${{ secrets.DOCKER_PASSWORD }}
Review comment:
Thanks for reminding. I applied to them to add secrets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
