[GitHub] [apisix-docker] gxthrj commented on a change in pull request #165: feat: build multi arch image

[GitBox]

gxthrj commented on a change in pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#discussion_r631541761



##########
File path: .github/workflows/apisix_push_docker_hub.yaml
##########
@@ -14,11 +14,30 @@ jobs:
     steps:
       - name: Check out the repo
         uses: actions/checkout@v2
+        with:
+          submodules: recursive
 
+      # Setup Buildx builder
+      - name: Setup Docker Buildx
+        uses: ./.github/actions/setup-buildx-action
+
+      # Login
       - name: Login
-        run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login --username=${{ 
secrets.DOCKER_USERNAME }} --password-stdin
+        uses: ./.github/actions/login-action
+        with:
+          username: ${{ secrets.DOCKER_USERNAME }}  

Review comment:
       As the [infra](https://issues.apache.org/jira/browse/INFRA-21756) says, 
need to use as below
   secrets.DOCKERHUB_USER
   secrets.DOCKERHUB_TOKEN




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org